Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IonReader.Builder(ionValue) #51

Merged
merged 22 commits into from
Jan 16, 2020
Merged

Conversation

R-maan
Copy link
Contributor

@R-maan R-maan commented Jan 16, 2020

*Issue #28 *
Adding an IonReader Builder with IonValue as input parameter.

@tgregg
Copy link
Contributor

tgregg commented Jan 16, 2020

Continues #46

@tgregg tgregg mentioned this pull request Jan 16, 2020
}

[TestMethod]
public void SymbolTableTest()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should test that UserTreeReader.GetSymbolTable returns the correct symbol table. To test this, create a binary Ion stream that contains two different symbol tables, each with one user symbol value in scope. Make sure that the values have the correct text and that calling UserTreeReader.GetSymbolTable when positioned at each value returns the expected symbol table.

However, looking at the source code, I don't think this will work as-is because the UserTreeReader changes its current symbol table based on the IIonValues it retrieves from SystemTreeReader. As we know, SystemTreeReader does not surface IIonValue representations of symbol tables (see #50 ). As a result, UserTreeReader will never change its current symbol table.

Therefore, let's drop this test and make UserTreeReader.GetSymbolTable throw an exception until #50 is resolved.

@tgregg tgregg merged commit dcbc595 into amazon-ion:master Jan 16, 2020
@R-maan R-maan deleted the ionreader-builder branch January 16, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants