Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .build(IonValue ionValue) to IonReaderBuilder #28

Closed
simonz-bq opened this issue Dec 13, 2019 · 2 comments
Closed

Add .build(IonValue ionValue) to IonReaderBuilder #28

simonz-bq opened this issue Dec 13, 2019 · 2 comments
Milestone
Preview

Comments

@simonz-bq
Copy link
Contributor

We need the ability to create an IonReader with an IonValue, as this functionality is used for Hashing and is available in the Java and JS implementations
@pbcornell
Copy link

Instead of adding .withValue(), I'd suggest continuing the existing IonReaderBuilder pattern by overloading .Build().

@simonz-bq simonz-bq changed the title Add .withValue to IonReaderBuilder Add .build(IonValue ionValue) to IonReaderBuilder Dec 14, 2019
@tgregg tgregg added this to the Preview milestone Dec 17, 2019
This was referenced Jan 10, 2020
Closed
Merged
@tgregg
Copy link
Contributor

tgregg commented Jan 16, 2020

Fixed in #51

@tgregg tgregg closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Preview
Development

No branches or pull requests
3 participants
@tgregg @pbcornell @simonz-bq