Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ion reader builder #46

Closed
wants to merge 9 commits into from
Closed

Conversation

R-maan
Copy link
Contributor

@R-maan R-maan commented Jan 10, 2020

*Issue #28 *

Adding an IonReader Builder with IonValue as input parameter.

@tgregg
Copy link
Contributor

tgregg commented Jan 10, 2020

Please rebase these changes onto the latest revision of master so that the diff doesn't include code that has already been merged.

@R-maan
Copy link
Contributor Author

R-maan commented Jan 10, 2020

Done. Sorry I didn't noticed it.

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port basically looks good, with a few comments below. However, we really need tests so we can verify it works.

In ion-java, the test that's directly relevant is TreeReaderTest. However, additional coverage is added in various tests parameterized by ReaderMaker (see ReaderMaker.FROM_DOM).

In ion-dotnet, we have ReaderTestCommon, which defines some common tests for readers. It looks like you could achieve roughly the same effect as ion-java's ReaderMaker (albeit without the fancy built-in test parameterization) by constructing UserTreeReaders over the appropriate input data via IonReaderBuilder and invoking a corresponding ReaderTestCommon test.

IonDotnet/Internals/Tree/SystemTreeReader.cs Outdated Show resolved Hide resolved
IonDotnet/Internals/Tree/UserTreeReader.cs Outdated Show resolved Hide resolved
IonDotnet/Internals/Tree/SystemTreeReader.cs Outdated Show resolved Hide resolved
IonDotnet/Internals/Tree/SystemTreeReader.cs Show resolved Hide resolved
IonDotnet/Internals/Tree/SystemTreeReader.cs Outdated Show resolved Hide resolved
IonDotnet/Internals/Tree/SystemTreeReader.cs Outdated Show resolved Hide resolved
IonDotnet/Internals/Tree/SystemTreeReader.cs Outdated Show resolved Hide resolved
IonDotnet/Internals/Tree/UserTreeReader.cs Outdated Show resolved Hide resolved
IonDotnet/Internals/Tree/SystemTreeReader.cs Show resolved Hide resolved
@tgregg
Copy link
Contributor

tgregg commented Jan 16, 2020

Closing in favor of #51

@tgregg tgregg closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants