SparseGrid and Transfers for MPM #21753
Conversation
Use drake::Parallelism
On laptop: p2g serial no simd: 55 ms p2g serial simd: 35 ms
Move all Transfer class implementation to .cc file
There was a problem hiding this comment.
+@amcastro-tri +@joemasterjohn for reviews please.
Please focus on things in the /multibody/mpm directory and ignore the changes in tools/.
I'd recommend starting from particles.* and sparse_grid.* and then work your way towards transfer.* while looking up definitions of helper classes/functions in auxiliary files along the way as needed.
Reviewable status: LGTM missing from assignees amcastro-tri,joemasterjohn, needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @xuchenhan-tri)
There was a problem hiding this comment.
Reviewed 39 of 56 files at r1.
Reviewable status: LGTM missing from assignees amcastro-tri,joemasterjohn, needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @xuchenhan-tri)
There was a problem hiding this comment.
Thanks @xuchenhan-tri!
FYI, Our highest priority with @joemasterjohn right now is to land margin to solve issues in Anzu. I am sorry, but our review of this will need to wait till next week. I believe that's not a blocker for you at this time. I'll review this ASAP after I'm done with the margin feature. Hopefully by end of week I can take a look or earlier next week.
Reviewable status: LGTM missing from assignees amcastro-tri,joemasterjohn, needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @xuchenhan-tri)
There was a problem hiding this comment.
Not a problem. I'm not blocked at the moment.
Reviewable status: LGTM missing from assignees amcastro-tri,joemasterjohn, needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @xuchenhan-tri)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignees amcastro-tri,joemasterjohn, needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @xuchenhan-tri)
a discussion (no related file):
I am trying to run some of the tests and they don't even compile.
Maybe a rebase is needed?
Thanks!
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignees amcastro-tri,joemasterjohn, needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @xuchenhan-tri)
a discussion (no related file):
Previously, amcastro-tri (Alejandro Castro) wrote…
I am trying to run some of the tests and they don't even compile.
Maybe a rebase is needed?
Thanks!
I disabled CI since we don't need it for this PR (not merging). Reverting the CI disabling commit locally should allow you to run the unit tests.
This change is