Fail explicit when default Database values differ #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return Command::SUCCESS; | ||
| $style->error('Some default values have the wrong type:'); | ||
| $style->listing($messages); | ||
| return Command::FAILURE; |
There was a problem hiding this comment.
Somehow it feels 'nicer' that the default outcome is success, so should we negate the if maybe?
There was a problem hiding this comment.
I agree it feels nicer, but I didn't like the negation, will implement a fix.
nickygerritsen
approved these changes
Aug 1, 2023
Also simplified the code by removing the else and using that as the default outcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplified the code by removing the else and using that as the default outcome.