Fail explicit when default Database values differ

Also simplified the code by removing the else and using that as the default outcome.
DOMjudge · Aug 1, 2023 · b69a414 · b69a414
1 parent 5a59d30
commit b69a414
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/webapp/src/Command/CheckDatabaseConfigurationDefaultValuesCommand.php b/webapp/src/Command/CheckDatabaseConfigurationDefaultValuesCommand.php
@@ -66,11 +66,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
         if (empty($messages)) {
             $style->success('All default values have the correct type');
-        } else {
-            $style->error('Some default values have the wrong type:');
-            $style->listing($messages);
+            return Command::SUCCESS;
         }
-
-        return Command::SUCCESS;
+        $style->error('Some default values have the wrong type:');
+        $style->listing($messages);
+        return Command::FAILURE;
     }
 }