Fail explicit when default Database values differ

Also simplified the code by removing the else and using that as the default outcome.
DOMjudge · Aug 1, 2023 · 5f08b6c · 5f08b6c
1 parent f5a1425
commit 5f08b6c
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/webapp/src/Command/CheckDatabaseConfigurationDefaultValuesCommand.php b/webapp/src/Command/CheckDatabaseConfigurationDefaultValuesCommand.php
@@ -64,13 +64,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                     break;
             }
         }
-        if (empty($messages)) {
-            $style->success('All default values have the correct type');
-        } else {
+        if (!empty($messages)) {
             $style->error('Some default values have the wrong type:');
             $style->listing($messages);
+            return Command::FAILURE;
         }
-
+        $style->success('All default values have the correct type');
         return Command::SUCCESS;
     }
 }