LINK-1359 | Signup presence_status field #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorilindell
force-pushed
the
feature/LINK-1359-presence_status
branch
from
eaef3cf
to
6a9a2f9
Compare
Codecov Report
@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 76.10% 76.17% +0.06%
==========================================
Files 242 241 -1
Lines 17400 17392 -8
==========================================
+ Hits 13242 13248 +6
+ Misses 4158 4144 -14
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jorilindell
force-pushed
the
feature/LINK-1359-presence_status
branch
from
b25b375
to
aea117e
Compare
- In PUT request, validate existing date_of_birth or mandatory field value the those attributes are missing from the payload
…uest if value is missing from the payload
- In PUT request, validate existing date_of_birth or mandatory field value the those attributes are missing from the payload
…uest if value is missing from the payload
jorilindell
force-pushed
the
feature/LINK-1359-presence_status
branch
from
abf9ec2
to
4b33108
Compare
jorilindell
force-pushed
the
feature/LINK-1359-presence_status
branch
from
cefbf01
to
8464278
Compare
|
Kudos, SonarCloud Quality Gate passed! |
harriris-vincit
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add presence_status field to Signup model. At the moment allowed values are
presentandnot_present, but we might later add some other values e.g.partially_present. That's the reason to use enum value instead of e.g. simple booleanis_presentfieldAlso allow mandatory_fields and
date_of_birthfield to undefined in the payload to update Signup. In that case use existing values for validationCloses
LINK-1359
Additional info
Link to FE PR: City-of-Helsinki/linkedcomponents-ui#206