Remove copy-pasted code in LibV2-LibV3 #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've spotted many duplicated codes in LibV3. This PR removes them, which will help us get a true picture of our C++ coverage and make maintenance easier.
Removing duplicates means:
Note: This PR doesn't address all old code redundancies. Some functions had been previously duplicated, but subsequently only one version had been updated. We should remember to check them later.
Tag
Tagged as 5.1
Squashed commits
delete LibV2::AP_begin_indices same impl exists in LibV3
rm LibV2::AP_end_indices same impl exists in LibV3
remove LibV3 rise and fall indices, same as LibV2
remove LibV3 interpolate, same as LibV1
remove LibV3 AP_duration, same as LibV2
remove LibV3 trace check, same as LibV1
rm LibV3 peak indices, same as LibV1
rm ISI_values and ISI_CV from LibV3, same in LibV1
Remove 4 more copy pasted functions in LibV3
rm min_ahp_idx & values duplicated code from libV3
rm LibV3 LibV3::AHP_depth_abs, same as LibV1
remove 3 more copy pasted code from LibV3
remove duplicated libv3 doublet_ISI implementation