Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Handling of Missing Values and Edge Cases Compromises Scientific Results #321

Closed
anilbey opened this issue Oct 13, 2023 · 1 comment

Comments

@anilbey
Copy link
Contributor

anilbey commented Oct 13, 2023

Inconsistent Handling of Missing Values and Edge Cases Compromises Scientific Results

Brief:

The current handling of edge cases, especially regarding missing values and certain exceptions in feature extraction, is inconsistent and blurs the distinction between missing and valid scientific values, corrupting our scientific results in downstream analyses, such as group feature extraction and optimisation.

Example problematic missing value representations:

'time_to_first_spike': None,
'time_to_last_spike': array([0.]),
'AP1_amp': array([], dtype=float64),
'decay_time_constant_after_stim': array([-1.])

Solution:

  1. Prune Redundant Features:
    Identify and remove unused and untested features, ensuring that documentation is updated accordingly.

  2. Standardise Missing Values and Edge Cases Handling:
    Develop solutions for handling missing values and specific exceptions consistently, ensuring clear and unambiguous representation and handling of all data points and states across all active features.

Changes:

@anilbey
Copy link
Contributor Author

anilbey commented Jan 15, 2024

This issue is resolved after merging 322, 323, 329 and 334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant