cppcore: implement memoization once for all features #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 55.65% 57.39% +1.73%
==========================================
Files 29 29
Lines 8046 7820 -226
Branches 3423 3235 -188
==========================================
+ Hits 4478 4488 +10
+ Misses 955 847 -108
+ Partials 2613 2485 -128
☔ View full report in Codecov by Sentry. |
anilbey
force-pushed
the
cache
branch
6 times, most recently
from
0782e88
to
da0e37e
Compare
anilbey
changed the title
efel/cppcore/cfeature.h
Outdated
| vector<double>& getmapDoubleData(string strName); | ||
|
|
||
| template <typename T> | ||
| const vector<T> getMapData(const string& strName, const map<string, vector<T>>& mapData) { |
There was a problem hiding this comment.
Not very familiar with c++ good practices, but shouldn't these three functions be in cfeature.cpp? With just their name declaration here in cfeature.h?
There was a problem hiding this comment.
Good point. Let me do it that way to be consistent with the rest of the methods of cFeature.
There was a problem hiding this comment.
Done in the last commit. Now the header file looks neat.
AurelienJaquier
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #321.
Memoization previously was done n_features times hence it was very hard to test.
There are ~150 C++ features. Each was performing a separate checking and retrieval of the cached results. Now there is only one implementation.
The responsibility of memoization is moved to cfeature. It became testable.
Does not introduce behavioural changes.
Scientists writing features (or reading them) do not have to worry about the underlying memoization mechanisms.
Uses C++17 for the
if constexpr (std::is_same_v<T, int>)that allows conditional compilation of templates.Note: CI image is updated to become ubuntu-22.04 since it uses gcc-11 by default. Otherwise we have to explicitly install gcc-11in each ci task. This change does not affect the users installing the wheels. They don't need to have a C++17 capable compiler. They'll be using the pre-compiled binaries we provide in the wheels.