-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace C++ exit(1) statements with exception handling #329
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 57.04% 57.05%
=======================================
Files 29 30 +1
Lines 7825 7847 +22
Branches 3264 3273 +9
=======================================
+ Hits 4464 4477 +13
- Misses 846 850 +4
- Partials 2515 2520 +5
☔ View full report in Codecov by Sentry. |
This reverts commit 954613a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me
When
exit(1)
is called within a C++ library that's being used by Python (e.g., through a Python API), it will terminate the entire process.This PR replaces the
exit(1)
statements with exception handling. It further translates C++ exceptions to Python's built-in exceptions to enable graceful failures.Given the frequent use of exit calls throughout eFEL – appearing in over 15 distinct locations, notably within the frequently used LinearInterpolation function – this update is expected to prevent approximately 95% of potential future crashes.
Related to #321 .