Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace C++ exit(1) statements with exception handling #329

Merged
merged 8 commits into from
Oct 20, 2023
Merged

replace C++ exit(1) statements with exception handling #329

merged 8 commits into from
Oct 20, 2023

Commits on Oct 20, 2023

  1. throw runtime_error, rm exit(1) in featuretype&calcfeatures

    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    0e6dbcd View commit details
    Browse the repository at this point in the history

  2. rename type->input_type

    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    5cc3c5e View commit details
    Browse the repository at this point in the history

  3. throw EfelAssertionError to avoid exit(-1)

    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    2a84582 View commit details
    Browse the repository at this point in the history

  4. add test to trigger C++->Python AssertionError

    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    84626df View commit details
    Browse the repository at this point in the history

  5. remove featurename.find(";") check

    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    954613a View commit details
    Browse the repository at this point in the history

  6. typo in docstring

    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e9cbcc8 View commit details
    Browse the repository at this point in the history

  7. add feature's name to the error message

    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    443e083 View commit details
    Browse the repository at this point in the history

  8. Revert "remove featurename.find(";") check" 

    This reverts commit 954613a.
    @anilbey
    anilbey committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f11e36d View commit details
    Browse the repository at this point in the history