Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copy-pasted code in LibV2-LibV3 #314

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Remove copy-pasted code in LibV2-LibV3 #314

merged 1 commit into from
Sep 14, 2023

Commits on Sep 13, 2023

  1. Remove copy-pasted code in LibV2-LibV3

    delete LibV2::AP_begin_indices same impl exists in LibV3
    
    rm LibV2::AP_end_indices same impl exists in LibV3
    
    remove LibV3 rise and fall indices, same as LibV2
    
    remove LibV3 interpolate, same as LibV1
    
    remove LibV3 AP_duration, same as LibV2
    
    remove LibV3 trace check, same as LibV1
    
    rm LibV3 peak indices, same as LibV1
    
    rm ISI_values and ISI_CV from LibV3, same in LibV1
    
    Remove 4 more copy pasted functions in LibV3
    
    rm min_ahp_idx & values duplicated code from libV3
    
    rm LibV3 LibV3::AHP_depth_abs, same as LibV1
    
    remove 3 more copy pasted code from LibV3
    
    remove duplicated libv3 doublet_ISI implementation
    anilbey committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    9678671 View commit details
    Browse the repository at this point in the history