-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyzer to detect missing ASP.NET Core integration registration #1917
Conversation
test/Sdk.Analyzers.Tests/RegistrationExpectedInAspNetIntegrationTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the implementation, but we need to make sure this analyzer is part of the ASP.NET Core integration package.
This reverts commit 226e3b4.
extensions/Worker.Extensions.Http.AspNetCore.Analyzers/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
...sions/Worker.Extensions.Http.AspNetCore.Analyzers/RegistrationExpectedInASPNetIntegration.cs
Outdated
Show resolved
Hide resolved
test/Worker.Extensions.Http.AspNetCore.Tests/Worker.Extensions.Http.AspNetCore.Tests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed having this analyzer only trigger if ConfigureFunctionsWorkerDefaults
is present and ConfigureFunctionsWebApplication
is not. Are we going with that approach or not?
I don't like the idea of having this analyzer trying to warn on the absence of something on IHostBuilder
without something extra to indicate this is intended to be a function app and they are not configuring at as we expect.
(Providing a brief summary below about the things we discussed to avoid any confusion) My understanding is we changed error to warning because absence of For this exact thing - this analyzer only trigger if Update - had an offline discussion. I have updated the code with this check. Thanks for catching this. |
Issue describing the changes in this PR
resolves #1902
Pull request checklist
release_notes.md
Additional information
Additional PR information