Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code fix suggestion for correct registration in ASP.NET core integration #1992

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Code fix suggestion for correct registration in ASP.NET core integration #1992

merged 5 commits into from
Oct 26, 2023

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Oct 25, 2023 •
edited
Loading

Issue describing the changes in this PR

resolves #1902

Code suggestion output will look like this -

image

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

kshyju
kshyju reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the latest version of the isolated worker.sdk package in the "LoadRequiredDependencyAssemblies" method

...Worker.Extensions.Http.AspNetCore.Analyzers/CodeFixForRegistrationInASPNetCoreIntegration.cs Outdated Show resolved Hide resolved
...Worker.Extensions.Http.AspNetCore.Analyzers/CodeFixForRegistrationInASPNetCoreIntegration.cs Outdated Show resolved Hide resolved
@surgupta-msft surgupta-msft merged commit 8238eda into main Oct 26, 2023
25 checks passed
@surgupta-msft surgupta-msft deleted the surgupta/codefix-aspnet-analyzer branch October 26, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju approved these changes

@liliankasem liliankasem Awaiting requested review from liliankasem

@fabiocav fabiocav Awaiting requested review from fabiocav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create analyzer to detect missing ASP.NET Core integration registration
2 participants
@surgupta-msft @kshyju