Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code fix suggestion for correct registration in ASP.NET core integration #1988

Closed
wants to merge 50 commits into from
Closed

Code fix suggestion for correct registration in ASP.NET core integration #1988

wants to merge 50 commits into from

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Oct 24, 2023 •
edited
Loading

Issue describing the changes in this PR

resolves #1902

Will update the target branch of this PR after #1917 is merged.

Code suggestion output will look like this -

image

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@surgupta-msft
Analyzer
6301376
@surgupta-msft
Add analyzer
c50dfe9
@surgupta-msft
Fix test
2d5b70b
@surgupta-msft
Adding docs for Analyzer
4819a5d
@surgupta-msft
Added tests for aspnet analyzer
047edbb
@surgupta-msft
Add more tests and code cleanup
d9c1665
@surgupta-msft
Addressing PR feedback
cb41c98
@surgupta-msft
Adding check for Main method
2bb5684
@surgupta-msft
Merge branch 'main' into surgupta/aspnet-analyzer
5309d78
@surgupta-msft
Updated analyzer check
bfd7b3a
@surgupta-msft
Making Analyzer as part of AspNet package
fb93b38
@surgupta-msft
Add analyzer as part of AspNet project
ba7f0b0
@surgupta-msft
Update sdk analyzer diagnostics
18edbcf
@surgupta-msft
Updating version
b097472
@surgupta-msft
Minor updates
23f0aac
@surgupta-msft
Minor csproj cleanup
7d460f3
@surgupta-msft
Adding a new project for AspNet analyzers
1b35d92
@surgupta-msft
Fix formatting in csproj file
6d2b485
@surgupta-msft
Removing unecessary check
a2ba972
@surgupta-msft
Merge branch 'main' into surgupta/aspnet-analyzer
eff85a8
@surgupta-msft
Test fix
a03e4a2
@surgupta-msft
Revert "Test fix"
90827fa 
This reverts commit a03e4a2.
@surgupta-msft
Test fix
7868a53
@surgupta-msft
Moving aspnet projects in a folder
aa2adfc
@surgupta-msft
Revert "Moving aspnet projects in a folder"
1cbf4f7 
This reverts commit aa2adfc.
@surgupta-msft
Fix typo
b9f2351
@surgupta-msft
Set diagnostic warning
0fcd2fd
@surgupta-msft
Adding new tests project for aspnet core
ba6aa87
@surgupta-msft
Added release notes
55c1d3e
@surgupta-msft
Updated analyzer rule doc
c7377e4
@surgupta-msft surgupta-msft marked this pull request as ready for review October 25, 2023 00:13
Base automatically changed from surgupta/aspnet-analyzer to main October 25, 2023 23:51
@surgupta-msft
Copy link
Contributor Author

Rebasing looks off. Will create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju Awaiting requested review from kshyju

@liliankasem liliankasem Awaiting requested review from liliankasem

@fabiocav fabiocav Awaiting requested review from fabiocav

@jviau jviau Awaiting requested review from jviau

@satvu satvu Awaiting requested review from satvu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create analyzer to detect missing ASP.NET Core integration registration
1 participant
@surgupta-msft