Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AARD-1671: Fission import panel modal #980

Merged
merged 14 commits into from
Jun 27, 2024
Merged

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jun 19, 2024

Added panel for local importing of mira files into the fission simulator.

JIRA Issue

@BrandonPacewic BrandonPacewic self-assigned this Jun 19, 2024
@BrandonPacewic BrandonPacewic requested a review from a team as a code owner June 19, 2024 16:30
@BrandonPacewic BrandonPacewic requested review from PepperLola and a-crowell and removed request for a team, PepperLola and a-crowell June 19, 2024 16:30
@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

@BrandonPacewic BrandonPacewic changed the base branch from branp/1687/parsing-options-refactor to dev June 19, 2024 16:35
@BrandonPacewic BrandonPacewic marked this pull request as draft June 19, 2024 17:12
@BrandonPacewic BrandonPacewic changed the title Barclah/mira upload Exporter file download / upload for the web Jun 20, 2024
@BrandonPacewic BrandonPacewic changed the title Exporter file download / upload for the web Fission / Exporter Integration Jun 20, 2024
@BrandonPacewic BrandonPacewic changed the title Fission / Exporter Integration Groundwork for fission / exporter integration Jun 20, 2024
@BrandonPacewic BrandonPacewic changed the title Groundwork for fission / exporter integration Fission exporter integration Jun 21, 2024
@BrandonPacewic BrandonPacewic changed the title Fission exporter integration AARD-1671: Fission import panel modal Jun 24, 2024
@BrandonPacewic BrandonPacewic marked this pull request as ready for review June 24, 2024 17:22
@BrandonPacewic BrandonPacewic requested review from HunterBarclay and PepperLola and removed request for HunterBarclay June 24, 2024 17:22
Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@HunterBarclay
Copy link
Member

@PepperLola I can't review this because I made it. Could you?

@BrandonPacewic BrandonPacewic removed the request for review from HunterBarclay June 26, 2024 21:28
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to import the 2024 KitBot locally from my computer. Is this something to make tests for once Playwright is integrated?

@HunterBarclay HunterBarclay merged commit 0921bc9 into dev Jun 27, 2024
10 of 12 checks passed
@HunterBarclay HunterBarclay deleted the barclah/mira-upload branch June 27, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants