scripts: add a script to fix gigadevice firmwares libs #19
Conversation
feilongfl
changed the title
scripts/lib_refactor/make_new_hal.sh
Outdated
| @@ -0,0 +1,27 @@ | |||
| #!/usr/bin/env fish | |||
There was a problem hiding this comment.
note: we should be using a common shell, ie bash.
|
Hi @feilongfl, Did you have time to review our comments? |
|
fixed |
scripts/lib_refactor/README.md
Outdated
| ## Dependencies | ||
|
|
||
| ``` | ||
| apt install fish | ||
| ``` |
There was a problem hiding this comment.
why do we need another shell to run refactor scripts?
scripts/lib_refactor/eval_patch.sh
Outdated
| if [ $# -ne 2 ] | ||
| then | ||
| echo "arguments error" | ||
| exit | ||
| fi | ||
|
|
||
| source_file=$2 | ||
| cocci=$1 | ||
|
|
||
| echo cocci: $cocci | ||
| echo source: $source_file | ||
|
|
||
| spatch -cocci_file $cocci $source_file | patch $source_file - |
There was a problem hiding this comment.
why not run this line directly?
scripts/lib_refactor/make_new_hal.sh
Outdated
| if [ $# -ne 1 ] | ||
| then | ||
| echo "arguments error" | ||
| exit | ||
| fi |
There was a problem hiding this comment.
please provide better error messages
| mkdir gd32c10x | ||
| unrar x /tmp/gd32c10x.rar gd32c10x | ||
| mv gd32c10x/*/* gd32c10x/ | ||
| scripts/lib_refactor/make_new_hal.sh gd32c10x |
There was a problem hiding this comment.
lib_refactor isn't probably a good name if it adds scripts to add a new HAL. I think that we should just provide a script to add a HAL (or update, which means remove and add), such script should also run patch scripts under the hood.
In fact, all the steps above could be handled by the script itself (download, uncompress, copy/delete, patch).
There was a problem hiding this comment.
I made a preliminary version and wanted to check if it meets your expectations.
Contains download, decompression, patch functions.
I'm not sure if it makes sense to remove hal.
|
Is this PR |
I think I need a little more time to implement the download and add/delete hal functions. |
feilongfl
force-pushed
the
dev-cocci
branch
2 times, most recently
from
7525b89
to
eec38d3
Compare
feilongfl
force-pushed
the
dev-cocci
branch
3 times, most recently
from
883b8e9
to
a1c65ef
Compare
gd32e10x: update HAL to v1.3.0 Signed-off-by: YuLong Yao <[email protected]>
apply fllowing patches for hal: - drop I2CCLK_MAX/I2CCLK_MIN - add `gd32_` prefix for timer_init - add ifdef to BIT macro - remove nvic_vector_table_set function call Signed-off-by: YuLong Yao <[email protected]>
link script readme to top readme Signed-off-by: YuLong Yao <[email protected]>
add script for auto import gigadevice hal Signed-off-by: YuLong Yao <[email protected]>
|
You need solve conflict due to #27 |
I learned the usage of
coccinelletoday and found that it is very suitable for migrate gigadevice libs tohal-gigadevice.I think it will be very useful when add firmwares for new chip
GD32_prefix forCAN_XXX_MODEandCAN_TIMEOUTmarconvic_vector_table_setfunction callBITmarcotimer_inittogd32_timer_initI2CCLK_MAX,I2CCLK_MIN,I2CCLK_FM_MIN,I2CCLK_FM_PLUS_MINinxxxx_i2c.hdrop
I2CCLK_MAX,I2CCLK_MINinxxxx_i2c.c