Add topic and partition to acknowledged_message event #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standalone producer includes the topic and partition in the instrumentation payload for
produce_async
events. However, when the broker acknowledges message delivery, the payload for theacknowledged_message
event only contains the partition and offset, but not the topic. This is of limited utility, since multiple topics are likely to have the same partition numbers.The rdkafka delivery report passed into the callback already includes the topic_name, so I added that information to the event payload. I also updated
Racecar::Datadog::ProducerSubscriber
to add tags for the topic and partition to theproducer.ack.messages
metric reported to StatsD.