Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic and partition to acknowledged_message event #381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maeve
Copy link

@maeve maeve commented Aug 9, 2024

The standalone producer includes the topic and partition in the instrumentation payload for produce_async events. However, when the broker acknowledges message delivery, the payload for the acknowledged_message event only contains the partition and offset, but not the topic. This is of limited utility, since multiple topics are likely to have the same partition numbers.

The rdkafka delivery report passed into the callback already includes the topic_name, so I added that information to the event payload. I also updated Racecar::Datadog::ProducerSubscriber to add tags for the topic and partition to the producer.ack.messages metric reported to StatsD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant