Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntcore] Various cleanups #7216

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

[ntcore] Various cleanups #7216

wants to merge 14 commits into from
+3,168 −2,803

Commits on Oct 15, 2024

  1. [ntcore] LocalStorage: Move template functions inside class definition

    @PeterJohnson
    PeterJohnson committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    239a2ea View commit details
    Browse the repository at this point in the history

  2. [ntcore] Value: Inline constructors

    @PeterJohnson
    PeterJohnson committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    30a997e View commit details
    Browse the repository at this point in the history

  3. [ntcore] NetworkOutgoingQueue: Move function defs inside class

    @PeterJohnson
    PeterJohnson committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    40dfc53 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. [ntcore] Move ServerImpl to nt::server namespace

    @PeterJohnson
    PeterJohnson committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    79c1281 View commit details
    Browse the repository at this point in the history

  2. [ntcore] Move ServerImpl detail classes to separate files

    @PeterJohnson
    PeterJohnson committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a48c529 View commit details
    Browse the repository at this point in the history

  3. [ntcore] Move ServerImpl.m_local to ServerClientLocal

    @PeterJohnson
    PeterJohnson committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    38330d3 View commit details
    Browse the repository at this point in the history

  4. [ntcore] Store client name instead of pointer in server pub/sub 

    This breaks the circular dependency between publisher/subscriber and client.
    @PeterJohnson
    PeterJohnson committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    05328c1 View commit details
    Browse the repository at this point in the history

  5. [ntcore] Make server publisher and subscriber classes 

    Add accessor functions where necessary.
    @PeterJohnson
    PeterJohnson committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a144257 View commit details
    Browse the repository at this point in the history

  6. [ntcore] Server: remove unused m_controlReady

    @PeterJohnson
    PeterJohnson committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e754518 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. [ntcore] Split ServerStorage out from ServerImpl

    @PeterJohnson
    PeterJohnson committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8afbfa0 View commit details
    Browse the repository at this point in the history

  2. [ntcore] ServerImpl: Move some creation to ServerClient4

    @PeterJohnson
    PeterJohnson committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e854fe1 View commit details
    Browse the repository at this point in the history

  3. [ntcore] ServerImpl: Refactor getting empty client slot

    @PeterJohnson
    PeterJohnson committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f05d085 View commit details
    Browse the repository at this point in the history

  4. [ntcore] ServerImpl: Inlining

    @PeterJohnson
    PeterJohnson committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c6f51be View commit details
    Browse the repository at this point in the history

  5. [ntcore] Move metatopic creation from SetLocal to constructor

    @PeterJohnson
    PeterJohnson committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b7a2b0f View commit details
    Browse the repository at this point in the history