[cmd] Add andThenWaitUntil, andThenWaitSeconds, andThenWaitTime command decorators
#7184
Conversation
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
| * @param seconds the timeout duration | ||
| * @return the command with the timeout to await | ||
| */ | ||
| public SequentialCommandGroup thenAwaitTimeout(double seconds) { |
There was a problem hiding this comment.
| public SequentialCommandGroup thenAwaitTimeout(double seconds) { | |
| public SequentialCommandGroup thenTimeout(double seconds) { |
There was a problem hiding this comment.
I think this might be a little less clear? Because you don't know what the timeout is there for.
But I think my choice of "timeout" is not very good, other suggestions are welcome
There was a problem hiding this comment.
Yes I think that's better! I'll change it tomorrow. Thank you
There was a problem hiding this comment.
Actually I wonder if it's not too similar to thenAwait.
| public SequentialCommandGroup thenAwaitTimeout(Time time) { | ||
| return thenAwaitTimeout(time.in(Seconds)); |
There was a problem hiding this comment.
| public SequentialCommandGroup thenAwaitTimeout(Time time) { | |
| return thenAwaitTimeout(time.in(Seconds)); | |
| public SequentialCommandGroup thenTimeout(Time time) { | |
| return thenTimeout(time.in(Seconds)); |
| HAL.initialize(500, 0); | ||
| SimHooks.pauseTiming(); | ||
| try (CommandScheduler scheduler = new CommandScheduler()) { | ||
| Command awaitTimeout = new RunCommand(() -> {}).thenAwaitTimeout(0.1); |
There was a problem hiding this comment.
| Command awaitTimeout = new RunCommand(() -> {}).thenAwaitTimeout(0.1); | |
| Command awaitTimeout = new RunCommand(() -> {}).thenTimeout(0.1); |
|
|
katzuv
changed the title
thenAwait and thenAwaitTimeout command decoratorsthenAwait and thenWait command decorators
|
/format |
|
Maybe |
I think "await" == "wait until", no? |
The format command won't work cause the PR is from the main branch of your form |
I created a new branch in my repo ( |
|
Java format is failing, locally you can just run ./gradlew spotlessApply which should fix it |
|
Personally I'd like these to be |
katzuv
changed the title
thenAwait and thenWait command decoratorsandThenWaitUntil, andThenWaitSeconds, andThenWaitTime command decorators
|
I'm not a fan of adding these.
You save two characters. |
True. I did imagine them more concise, with it initially being |
I can add Python later and try to add C++ implementation. English is not my first language, so I'd appreciate suggestion for improving the docs.