Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use db_version for col_version" #405

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

tantaman
Copy link
Collaborator

Reverts #386

@tantaman
Copy link
Collaborator Author

This breaks the previous causal relationships we had for cells.

In other words, if an agent never saw updates to a cell then writes the cell, they could win that write everywhere because of a large db version.

Keeping the column independently versioned means that the happens-before relationship is tied directly to the cell itself.

We do lose the ability to set many columns together, however. This guarantee only existed if the columns in question were always set together on all nodes though.

E.g.,

set x, y is always issued on every node.

@tantaman
Copy link
Collaborator Author

Also revert : #393

#393 can't be automatically reverted so I'll need to handle this manually.

@tantaman tantaman merged commit e8def14 into main Nov 22, 2023
9 checks passed
@tantaman tantaman mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant