Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASN1 binaries to include updates required for BSMs, TCMs, and EmergencyVehicleAck messages after merging master to develop #183

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

JonSmet
Copy link
Contributor

@JonSmet JonSmet commented Feb 27, 2023

PR Details

Description

While merging master to develop (PR #182), it was discovered that the asn1 binaries on the master branch did not contain all necessary compiled code to encode/decode the BSMs, TrafficControlMessages, and EmergencyVehicleAck messages. This PR fixes this issue by re-compiling the latest asn1 file used for CARMA, and replacing the old binary files in CARMA Messenger.

Related Issue

Issue #184

Motivation and Context

How Has This Been Tested?

Originally, unit tests were failing in the cpp_message package from BSMs, TrafficControlMessages, and EmergencyVehicleAck messages. Now all unit tests pass.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car merged commit b3d7f28 into develop Feb 27, 2023
@dan-du-car dan-du-car deleted the fix/asn1_binaries branch February 27, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants