Skip to content

Commit

Permalink
Fix ASN1 binaries to include updates required for BSMs, TCMs, and Eme…
Browse files Browse the repository at this point in the history
…rgencyVehicleAck messages after merging master to develop (#183)

<!-- Thanks for the contribution, this is awesome. -->

# PR Details
## Description

<!--- Describe your changes in detail -->
While merging `master` to `develop` (PR #182), it was discovered that
the asn1 binaries on the `master` branch did not contain all necessary
compiled code to encode/decode the BSMs, TrafficControlMessages, and
EmergencyVehicleAck messages. This PR fixes this issue by re-compiling
the latest asn1 file used for CARMA, and replacing the old binary files
in CARMA Messenger.

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please DO NOT name partially fixed issues, instead open an issue
specific to this fix -->
<!--- Please link to the issue here: -->
Issue #184 

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
Originally, unit tests were failing in the cpp_message package from
BSMs, TrafficControlMessages, and EmergencyVehicleAck messages. Now all
unit tests pass.

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Defect fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that cause existing functionality
to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have added any new packages to the sonar-scanner.properties file
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the
[**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md)
document.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
  • Loading branch information
dan-du-car authored Feb 27, 2023
2 parents ce904bd + 3ac3dd9 commit b3d7f28
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 0 deletions.
Binary file not shown.
Binary file modified carma-messenger-core/lib_asn1c/third_party_lib/libasn1c_x86.so
Binary file not shown.

0 comments on commit b3d7f28

Please sign in to comment.