Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libraries #4349

Merged
merged 1 commit into from
Nov 1, 2024
Merged

add libraries #4349

merged 1 commit into from
Nov 1, 2024

Conversation

domdinicola
Copy link
Collaborator

No description provided.

@domdinicola domdinicola force-pushed the add-libs branch 3 times, most recently from 424d10b to 9425a4f Compare October 28, 2024 12:07
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (797c740) to head (894c224).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/config/fragments/storages.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4349      +/-   ##
===========================================
- Coverage    77.97%   77.76%   -0.22%     
===========================================
  Files          943      942       -1     
  Lines        44502    44442      -60     
===========================================
- Hits         34702    34559     -143     
- Misses        9800     9883      +83     
Flag Coverage Δ
e2e 54.45% <92.30%> (-2.44%) ⬇️
unittests 76.64% <88.46%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -138,7 +138,7 @@ distribution = true

[project]
name = "hope"
version = "2.12.0"
version = "3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.b.c ?? or now it will be v 3

@pavlo-mk pavlo-mk self-requested a review October 29, 2024 09:49
@domdinicola domdinicola force-pushed the add-libs branch 10 times, most recently from c822021 to 893394a Compare October 31, 2024 11:03
@domdinicola domdinicola merged commit 90f4c88 into develop Nov 1, 2024
12 of 13 checks passed
@domdinicola domdinicola deleted the add-libs branch November 1, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants