Skip to content

Commit

Permalink
cleaning env
Browse files Browse the repository at this point in the history
  • Loading branch information
domdinicola committed Oct 31, 2024
1 parent 797c740 commit c822021
Show file tree
Hide file tree
Showing 24 changed files with 473 additions and 535 deletions.
1 change: 0 additions & 1 deletion .github/helpers/.env-selenium
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
REDIS_INSTANCE=redis:6379
PYTHONUNBUFFERED=1
SECRET_KEY=secretkey
ENV=dev
Expand Down
1 change: 0 additions & 1 deletion .github/helpers/.env-unit
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ KOBO_KF_URL=https://kobo.humanitarianresponse.info
KOBO_KC_URL=https://kobo.humanitarianresponse.info
KOBO_MASTER_API_TOKEN=token
EXCHANGE_RATES_API_KEY=token
REDIS_INSTANCE=redis:6379
PYTHONUNBUFFERED=1
2 changes: 1 addition & 1 deletion .github/helpers/docker-compose.selenium.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ services:
- backend-web-app:/tmp/
command: |
sh -c "
cp -r /packages/__pypackages__/3.11/lib/hct_mis_api/apps/web/* /tmp/
cp -r /packages/__pypackages__/3.12/lib/hct_mis_api/apps/web/* /tmp/
"
restart: "no"

Expand Down
6 changes: 0 additions & 6 deletions development_tools/compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ services:
env_file:
- .env
environment:
- REDIS_INSTANCE=redis:6379
- PYTHONUNBUFFERED=1
build:
context: ..
Expand Down Expand Up @@ -61,8 +60,6 @@ services:
image: unicef/hct-mis-backend
env_file:
- .env
environment:
- REDIS_INSTANCE=redis:6379
volumes:
- ../src:/code/
- backend-data:/data
Expand Down Expand Up @@ -90,8 +87,6 @@ services:
image: unicef/hct-mis-backend
env_file:
- .env
environment:
- REDIS_INSTANCE=redis:6379
volumes:
- ../src:/code/
- backend-data:/data
Expand Down Expand Up @@ -186,7 +181,6 @@ services:
ports:
- "5555:5555"
environment:
- REDIS_INSTANCE=redis:6379
- CELERY_BROKER_URL=redis://redis:6379/0
- CELERY_RESULT_BACKEND=redis://redis:6379/0
- PYTHONUNBUFFERED=1
Expand Down
2 changes: 0 additions & 2 deletions development_tools/local_selenium_init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ export KOBO_KF_URL=https://kobo.humanitarianresponse.info
export KOBO_KC_URL=https://kobo.humanitarianresponse.info
export ADMIN_PANEL_URL=unicorn
export PROFILING=off
export CYPRESS_TESTING=yes
export DJANGO_ALLOWED_HOST=localhost
export HCT_MIS_FRONTEND_HOST=localhost:8080
export REDIS_INSTANCE=localhost:6379
export PYTHONUNBUFFERED=1
export CELERY_BROKER_URL=redis://localhost:6379/0
export CELERY_RESULT_BACKEND=redis://localhost:6379/0
Expand Down
7 changes: 4 additions & 3 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ FROM curl as certs
RUN curl -o /data/psql-cert.crt -L https://dl.cacerts.digicert.com/DigiCertGlobalRootCA.crt.pem

# Base image
FROM python:3.11.7-slim-bookworm as base
FROM python:3.12.7-slim-bookworm as base

ARG UID=82

Expand Down Expand Up @@ -42,7 +42,7 @@ RUN apt-get update \
ENV PDM_PACKAGES=/packages
ENV CODE=/code
ENV PDM_PROJECT=$PDM_PACKAGES
ENV PYPACKAGES=$PDM_PACKAGES/__pypackages__/3.11
ENV PYPACKAGES=$PDM_PACKAGES/__pypackages__/3.12
ENV PYTHONPYCACHEPREFIX=/tmp/pycache \
PYTHONPATH=$PYPACKAGES/lib:$PYTHONPATH \
PATH=$PYPACKAGES/bin:$PATH \
Expand All @@ -55,7 +55,8 @@ COPY --from=waitforit /data/waitforit /usr/local/bin/waitforit
# Dist builder image
FROM base as pdm
RUN pip install --upgrade pip &&\
pip install pdm==2.15.2 &&\
pip install pdm==2.19.2 &&\
pip install pdm-backend &&\
pip install setuptools==71.1.0 &&\
pdm config cache_dir /var/cache/pdm &&\
pdm config python.use_venv false &&\
Expand Down
754 changes: 361 additions & 393 deletions pdm.lock

Large diffs are not rendered by default.

9 changes: 5 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ exclude = '''
'''
# TODO: remove migrations exclude rule once it won't create much conflicts between feature branches and develop
[tool.isort]
py_version = 39
py_version = 312
profile = "black"
default_section = "THIRDPARTY"
known_first_party = [
Expand All @@ -48,7 +48,7 @@ include_trailing_comma = true
skip = ["migrations", "snapshots", "venv", ".venv", "__pypackages__", "frontend"]

[tool.mypy]
python_version = 3.11
python_version = 3.12
show_error_codes = true
exclude = [
"migrations",
Expand Down Expand Up @@ -137,7 +137,7 @@ distribution = true

[project]
name = "hope"
version = "2.12.0"
version = "3.0.0"
description = "HCT MIS is UNICEF's humanitarian cash transfer platform."
authors = [
{ name = "Tivix" },
Expand Down Expand Up @@ -190,6 +190,7 @@ dependencies = [
"django-reversion<6.0.0,>=5.0.2",
"django-silk<6.0.0,>=5.0.1",
"django-smart-admin<3,>=2",
"django-smart-env",
"django-sql-explorer[xls]<4,>=3",
"django-storages[azure]<2.0.0,>=1.12.3",
"django-strategy-field<4.0,>=3.0",
Expand Down Expand Up @@ -239,7 +240,7 @@ dependencies = [
"flower>=2.0.1",
"factory-boy<4,>=3",
]
requires-python = "==3.11.*"
requires-python = "==3.12.*"
readme = "README.md"
license = { text = "None" }

Expand Down
8 changes: 5 additions & 3 deletions src/hct_mis_api/apps/grievance/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@ class Meta:
business_area = factory.LazyAttribute(lambda o: BusinessArea.objects.first())
created_at = factory.Faker("date_time_this_decade", before_now=False, after_now=True, tzinfo=utc)
issue_type = factory.LazyAttribute(
lambda o: factory.fuzzy.FuzzyChoice(list(GrievanceTicket.ISSUE_TYPES_CHOICES.get(o.category, {}).keys())).fuzz()
if GrievanceTicket.ISSUE_TYPES_CHOICES.get(o.category)
else None
lambda o: (
factory.fuzzy.FuzzyChoice(list(GrievanceTicket.ISSUE_TYPES_CHOICES.get(o.category, {}).keys())).fuzz()
if GrievanceTicket.ISSUE_TYPES_CHOICES.get(o.category)
else None
)
)


Expand Down
8 changes: 5 additions & 3 deletions src/hct_mis_api/apps/program/mutations.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,11 @@ def processed_mutate(cls, root: Any, info: Any, program_data: Dict) -> "CreatePr

cls.validate(
start_date=datetime.combine(program_data["start_date"], datetime.min.time()),
end_date=datetime.combine(program_data["end_date"], datetime.min.time())
if program_data.get("end_date")
else None,
end_date=(
datetime.combine(program_data["end_date"], datetime.min.time())
if program_data.get("end_date")
else None
),
data_collecting_type=data_collecting_type,
business_area=business_area,
programme_code=programme_code,
Expand Down
12 changes: 6 additions & 6 deletions src/hct_mis_api/apps/program/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,9 @@ def copy_program_related_data(copy_from_program_id: str, new_program: Program, u
rdi = RegistrationDataImport.objects.create(
name=f"Default RDI for Programme: {new_program.name}",
status=RegistrationDataImport.MERGED,
deduplication_engine_status=RegistrationDataImport.DEDUP_ENGINE_PENDING
if new_program.biometric_deduplication_enabled
else None,
deduplication_engine_status=(
RegistrationDataImport.DEDUP_ENGINE_PENDING if new_program.biometric_deduplication_enabled else None
),
imported_by=User.objects.get(id=user_id),
data_source=RegistrationDataImport.PROGRAM_POPULATION,
number_of_individuals=copy_from_individuals.count(),
Expand Down Expand Up @@ -398,9 +398,9 @@ def enroll_households_to_program(households: QuerySet, program: Program, user_id
error_messages = []
rdi = RegistrationDataImport.objects.create(
status=RegistrationDataImport.MERGED,
deduplication_engine_status=RegistrationDataImport.DEDUP_ENGINE_PENDING
if program.biometric_deduplication_enabled
else None,
deduplication_engine_status=(
RegistrationDataImport.DEDUP_ENGINE_PENDING if program.biometric_deduplication_enabled else None
),
imported_by=User.objects.get(id=user_id),
data_source=RegistrationDataImport.ENROLL_FROM_PROGRAM,
number_of_individuals=0,
Expand Down
63 changes: 0 additions & 63 deletions src/hct_mis_api/apps/utils/cypress.py

This file was deleted.

47 changes: 44 additions & 3 deletions src/hct_mis_api/config/env.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
from environ import Env
from smart_env import SmartEnv

DEFAULTS = {
"AURORA_SERVER": (str, ""),
"AURORA_TOKEN": (str, ""),
"AURORA_USER": (str, ""),
"DATABASE_URL": (
str,
"sqlite://",
"",
"",
"https://django-environ.readthedocs.io/en/latest/types.html#environ-env-db-url",
),
"DEBUG": (bool, False),
"ENV": (str, "dev"),
"DOMAIN": (str, "localhost:8000"),
"DJANGO_ALLOWED_HOSTS": (list, "*"),
"DJANGO_ALLOWED_HOSTS": (list, []),
"HCT_MIS_FRONTEND_HOST": (str, ""),
"ALERTS_EMAIL": (str, "[email protected]"),
"SECRET_KEY": (str, ""),
Expand All @@ -20,16 +27,21 @@
"EMAIL_HOST_USER": (str, ""),
"EMAIL_HOST_PASSWORD": (str, ""),
"EMAIL_USE_TLS": (bool, True),
"DEFAULT_EMAIL": (str, ""),
"MAILJET_API_KEY": (str, ""),
"MAILJET_SECRET_KEY": (str, ""),
"CATCH_ALL_EMAIL": (list, []),
"DEFAULT_EMAIL_DISPLAY": (list, []),
"KOBO_KF_URL": (str, "https://kf-hope.unitst.org"),
"KOBO_KC_URL": (str, "https://kc-hope.unitst.org"),
"KOBO_MASTER_API_TOKEN": (str, "KOBO_TOKEN"),
"AZURE_CLIENT_ID": (str, ""),
"AZURE_CLIENT_SECRET": (str, ""),
"AZURE_TENANT_KEY": (str, ""),
"CONSTANCE_REDIS_CONNECTION": (str, "redis://redis:6379/0"),
"SANCTION_LIST_CC_MAIL": (str, "[email protected]"),
"ELASTICSEARCH_HOST": (str, "http://elasticsearch:9200"),
"ELASTICSEARCH_INDEX_PREFIX": (str, ""),
"RAPID_PRO_URL": (str, "https://rapidpro.io"),
"DATAMART_USER": (str, ""),
"DATAMART_URL": (str, "https://datamart-dev.unicef.io"),
Expand All @@ -54,6 +66,7 @@
"SECURE_HSTS_SECONDS": (int, 3600),
"FLOWER_ADDRESS": (str, "https://hope.unicef.org/flower"),
"CACHE_ENABLED": (bool, True),
"CACHE_LOCATION": (str, "redis://redis:6379/1"),
"CSP_REPORT_URI": (tuple, ("",)),
"CSP_REPORT_ONLY": (bool, True),
"CSP_REPORT_PERCENTAGE": (float, 0.1),
Expand Down Expand Up @@ -112,6 +125,34 @@
str,
"",
),
"SOCIAL_AUTH_REDIRECT_IS_HTTPS": (bool, True),
"LOG_LEVEL": (str, "ERROR"),
"POSTGRES_SSL": (bool, False),
"GIT_VERSION": (str, "UNKNOWN"),
"EXCHANGE_RATE_CACHE_EXPIRY": (int, 60 * 60 * 24),
"USE_DUMMY_EXCHANGE_RATES": (str, "no"),
"PROFILING": (str, "off"),
"LIBRARY_PATHS": (bool, False),
"STATIC_URL": (str, "/static/"),
"MEDIA_URL": (str, "/media/"),
"FILE_STORAGE_STATIC": (
str,
"django.core.files.storage.FileSystemStorage",
),
"FILE_STORAGE_MEDIA": (
str,
"django.core.files.storage.FileSystemStorage",
),
"STORAGE_AZURE_ACCOUNT_NAME": (str, ""),
"STORAGE_AZURE_ACCOUNT_KEY": (str, ""),
"MEDIA_STORAGE_AZURE_ACCOUNT_NAME": (str, ""),
"MEDIA_STORAGE_AZURE_ACCOUNT_KEY": (str, ""),
"STATIC_STORAGE_AZURE_ACCOUNT_NAME": (str, ""),
"STATIC_STORAGE_AZURE_ACCOUNT_KEY": (str, ""),
"STATIC_LOCATION": (str, "static"),
"MEDIA_LOCATION": (str, "media"),
"AZURE_ACCOUNT_NAME": (str, ""),
"AZURE_ACCOUNT_KEY": (str, ""),
}

env = Env(**DEFAULTS)
env = SmartEnv(**DEFAULTS)
7 changes: 4 additions & 3 deletions src/hct_mis_api/config/fragments/celery.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
from hct_mis_api.apps.core.tasks_schedules import TASKS_SCHEDULES
from hct_mis_api.config.env import env
from hct_mis_api.config.settings import REDIS_INSTANCE

CELERY_BROKER_URL = env("CELERY_BROKER_URL", default=f"redis://{REDIS_INSTANCE}/0")
CELERY_BROKER_URL = env("CELERY_BROKER_URL")
CELERY_ACCEPT_CONTENT = ["json"]
CELERY_TASK_SERIALIZER = "json"
CELERY_RESULT_SERIALIZER = "json"
CELERY_RESULT_BACKEND = env("CELERY_RESULT_BACKEND", default=f"redis://{REDIS_INSTANCE}/0")
CELERY_RESULT_BACKEND = env("CELERY_RESULT_BACKEND")
CELERY_TIMEZONE = "UTC"
CELERY_TASK_TRACK_STARTED = True
CELERY_TASK_TIME_LIMIT = 360 * 60
CELERY_BEAT_SCHEDULE = TASKS_SCHEDULES
CELERY_TASK_ALWAYS_EAGER = env.bool("CELERY_TASK_ALWAYS_EAGER")
CELERY_TASK_DEFAULT_QUEUE = env.str("CELERY_TASK_DEFAULT_QUEUE")
CELERY_TASK_REVOKED_QUEUE = env.str("CELERY_TASK_REVOKED_QUEUE")
3 changes: 1 addition & 2 deletions src/hct_mis_api/config/fragments/constance.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
from django.utils.translation import gettext_lazy as _

from hct_mis_api.config.env import env
from hct_mis_api.config.settings import REDIS_INSTANCE

CONSTANCE_REDIS_CONNECTION = env("CONSTANCE_REDIS_CONNECTION", default=f"redis://{REDIS_INSTANCE}/0")
CONSTANCE_REDIS_CONNECTION = env("CONSTANCE_REDIS_CONNECTION")
CONSTANCE_REDIS_CACHE_TIMEOUT = 1
CONSTANCE_ADDITIONAL_FIELDS = {
"percentages": (
Expand Down
2 changes: 1 addition & 1 deletion src/hct_mis_api/config/fragments/csp.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@
CSP_STYLE_SRC += (FRONTEND_HOST,)
CSP_MANIFEST_SRC += (FRONTEND_HOST,)

ALLOWED_HOSTS.extend(["backend", "localhost", "127.0.0.1", "10.0.2.2", env("DOMAIN", default="")])
ALLOWED_HOSTS.extend(["backend", "localhost", "127.0.0.1", "10.0.2.2", env("DOMAIN")])
2 changes: 1 addition & 1 deletion src/hct_mis_api/config/fragments/es.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# ELASTICSEARCH SETTINGS
ELASTICSEARCH_DSL_AUTOSYNC = False
ELASTICSEARCH_HOST = env("ELASTICSEARCH_HOST")
ELASTICSEARCH_INDEX_PREFIX = env("ELASTICSEARCH_INDEX_PREFIX", default="")
ELASTICSEARCH_INDEX_PREFIX = env("ELASTICSEARCH_INDEX_PREFIX")
ELASTICSEARCH_DSL = {
"default": {"hosts": ELASTICSEARCH_HOST, "timeout": 30},
}
Expand Down
Loading

0 comments on commit c822021

Please sign in to comment.