This repository has been archived by the owner on Feb 2, 2018. It is now read-only.
fix #DH176 sidebar navigation on details page to match designs and re… #45
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| // TODO move globally or into the config ? has to be the same as the media query for tablets | ||
| const enableIfScreenSmallerThan = 641 | ||
| const DOM_EL_WINDOW = '.tabbedwindow' | ||
| const DOM_EL_TAB = '.tabbedwindow__tab' | ||
| const DOM_EL_TAB_ICON = '.tabbedwindow__tab__icon' | ||
| const DOM_EL_NAV = '.tabbedwindow__nav' | ||
| const DOM_EL_PANE = '.tabbedwindow__pane' | ||
|
|
||
| const CSS_CLASS_TAB = `${DOM_EL_TAB}`.replace('.', '') | ||
| const CSS_CLASS_TAB_ACTIVE = `${CSS_CLASS_TAB}--active` | ||
|
|
||
| let toggleEnabled = null | ||
|
|
||
| function TabbedWindow () { | ||
| this.toggleEnabled = null | ||
| this.domEl = document.querySelector(DOM_EL_WINDOW) | ||
| this.domElTabs = [].slice.call(document.querySelectorAll(DOM_EL_TAB)) | ||
| this.domElNav = document.querySelector(DOM_EL_NAV) | ||
| this.domElPane = document.querySelector(DOM_EL_PANE) | ||
| } | ||
|
|
||
| TabbedWindow.prototype = { | ||
| onActiveItems: function () { | ||
| return document.querySelectorAll(CSS_CLASS_TAB_ACTIVE) | ||
| }, | ||
| getNonActiveItems: function () { | ||
| return this.domElTabs.filter(tab => tab.classList.contains(CSS_CLASS_TAB_ACTIVE) === false) | ||
| }, | ||
| disableActiveLink: function () { | ||
| return document.querySelector('.' + CSS_CLASS_TAB_ACTIVE).setAttribute('onclick', 'return false') | ||
| }, | ||
|
|
||
| isItemCollapsed: function (item) { | ||
| let chevron = item.querySelector(DOM_EL_TAB_ICON) | ||
| return chevron.classList.contains('fa-chevron-down') | ||
| }, | ||
|
|
||
| getActiveItem: function () { | ||
| return document.querySelector(`.${CSS_CLASS_TAB_ACTIVE}`) | ||
| }, | ||
|
|
||
| setChevronUp: function (item) { | ||
| let chevron = item.querySelector(DOM_EL_TAB_ICON) | ||
| chevron.classList.remove('fa-chevron-down') | ||
| chevron.className += ' fa-chevron-up ' | ||
| }, | ||
|
|
||
| setChevronDown: function (item) { | ||
| let chevron = item.querySelector(DOM_EL_TAB_ICON) | ||
| chevron.classList.remove('fa-chevron-up') | ||
| chevron.className += ' fa-chevron-down ' | ||
| }, | ||
|
|
||
| show: function (items) { | ||
| [].forEach.call(items, function (a) { | ||
| a.style.display = null | ||
| }) | ||
| }, | ||
|
|
||
| hide: function (items) { | ||
| [].forEach.call(items, function (a) { | ||
| a.style.display = 'none' | ||
| }) | ||
| }, | ||
| updateDisplay: function () { | ||
| // @TODO stop calling updateDisplay resize | ||
| // running dom queries on window resize is bad for performance | ||
| // switch to event driven UI (JS Events) | ||
| let screenIsSmall = document.documentElement.clientWidth <= enableIfScreenSmallerThan | ||
| if (screenIsSmall) { | ||
| this.hide(this.getNonActiveItems()) | ||
| this.toggleEnabled = true | ||
| this.disableActiveLink() | ||
| } else { | ||
| this.setChevronDown(this.getActiveItem()) | ||
| this.show(this.domElTabs) | ||
| this.toggleEnabled = false | ||
| } | ||
| }, | ||
| onTabClick: function (e) { | ||
| let el = e.target | ||
| if (!el.classList.contains(CSS_CLASS_TAB)) { | ||
| return | ||
| } | ||
| if (!this.toggleEnabled) { | ||
| return | ||
| } | ||
| if (this.isItemCollapsed(el)) { | ||
| this.setChevronUp(el) | ||
| this.show(this.getNonActiveItems()) | ||
| } else { | ||
| this.setChevronDown(el) | ||
| this.hide(this.getNonActiveItems()) | ||
| } | ||
| }, | ||
| init: function () { | ||
| // @TODO setinterval on resize callback being fired for performance reason | ||
| window.addEventListener('resize', this.updateDisplay.bind(this)) | ||
| window.addEventListener('load', this.updateDisplay.bind(this)) | ||
| // expand/collapse logic | ||
|
|
||
| this.domEl.addEventListener('click', this.onTabClick.bind(this)) | ||
| console.log('TabWindow initialied!') | ||
| console.log(this) | ||
|
|
||
| } | ||
| } | ||
|
|
||
| module.exports = TabbedWindow | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| const TabbedWindow = require('../../components/TabbedWindow') | ||
| let oTabbedWindow = new TabbedWindow() | ||
|
|
||
| oTabbedWindow.init() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| .tabbedwindow { | ||
| @extend .clearfix; | ||
| // layout | ||
| &__nav, &__pane { | ||
| float:left; | ||
| } | ||
| &__nav { | ||
| width:25%; | ||
| // @extend %site-width-container; | ||
|
There was a problem hiding this comment. remove commented out code if this is a finished file |
||
| // @extend %contain-floats; | ||
| // clear: both; | ||
|
|
||
| } | ||
| &__pane { | ||
| margin-left:10%; | ||
| width:65%; | ||
| } | ||
| &__tab { | ||
| display:block; | ||
| height:50px; | ||
| padding-left:1rem; | ||
| vertical-align:middle; | ||
| line-height: 50px; | ||
| text-decoration: underline; | ||
| position:relative; | ||
| &:hover, &:visited { | ||
| color:$black; | ||
| } | ||
| &--active { | ||
| background:$govuk-blue; | ||
| color:$white; | ||
| font-weight: bold; | ||
| text-decoration: none; | ||
| &:hover, &:visited { | ||
| color:$white; | ||
| } | ||
| & .tabbedwindow__tab__icon { | ||
| display: block; | ||
| } | ||
| @include media (tablet) { | ||
| & .tabbedwindow__tab__icon { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| } | ||
| &__icon { | ||
| color:$white; | ||
| position: absolute; | ||
| right:1rem; | ||
| top: 50%; | ||
| transform:translate3d(0, -50%, 0); | ||
| display: none; | ||
| @include media(tablet) { | ||
| display: none; | ||
| } | ||
| // &.fa { | ||
| // display:none; | ||
| // } | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is going to hurt - don't we have a debounce function lying around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could write one if we don't have one already?
I have just realised we are using lodash already in this project so can use the one included there