This repository has been archived by the owner on Feb 2, 2018. It is now read-only.
fix #DH176 sidebar navigation on details page to match designs and re… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-factor assets add tabwindow and add sourcemaps to npm run develop re-factor side tab nav js fix collapse icon state bug in tabbed window when switching between tablet and desktop views rename component to TabbedWindow
jim68000
previously requested changes
May 3, 2017
src/lib/components/TabbedWindow.js
Outdated
|
|
||
| this.domEl.addEventListener('click', this.onTabClick.bind(this)) | ||
| console.log('TabWindow initialied!') | ||
| console.log(this) |
src/lib/components/TabbedWindow.js
Outdated
| }, | ||
| init: function () { | ||
| // @TODO setinterval on resize callback being fired for performance reason | ||
| window.addEventListener('resize', this.updateDisplay.bind(this)) |
There was a problem hiding this comment.
yeah this is going to hurt - don't we have a debounce function lying around?
There was a problem hiding this comment.
i could write one if we don't have one already?
I have just realised we are using lodash already in this project so can use the one included there
| } | ||
| &__nav { | ||
| width:25%; | ||
| // @extend %site-width-container; |
There was a problem hiding this comment.
remove commented out code if this is a finished file
src/sass/settings/_variables.scss
Outdated
| $mobile-break-point-max:320px; | ||
|
|
||
| // $tablet-breakpoint: 641px !default; | ||
| // $desktop-breakpoint: 769px !default; |
src/views/investment/container.html
Outdated
| </section> | ||
|
|
||
|
|
||
| {# <div class="left-nav-container"> | ||
| <div class="left-nav"> |
There was a problem hiding this comment.
delete commented out code if not here for a good reason
|
have removed the comments and console logs Also have implemented the event driven architecture mentioned in one of those comments just to reduce tech debt Using events should make things easier to test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-factored assets
add tabwindow and add sourcemaps to npm run develop
re-factor side tab nav js
fix collapse icon state bug in tabbed window when switching between tablet and desktop views
rename component to TabbedWindow
jira issue:
https://uktrade.atlassian.net/browse/DH-176