Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed manually installation govulncheck in Makefile #1466

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removed manually installation govulncheck in Makefile #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c579e68
Update go.yml
Spuxy Oct 22, 2024
935a027
Update Makefile for govulncheck action
Spuxy Oct 22, 2024
55994a7
removed manually installation
Spuxy Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ jobs:
# Hack: Use the official action to download, but not run.
# make lint below will handle actually running the linter.
args: --help

- uses: golang/govulncheck-action@v1
name: Install govulncheck
with:
go-version-input: 1.23.x
go-package: all

- run: make lint
name: Lint
Expand Down
8 changes: 2 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ PROJECT_ROOT = $(dir $(abspath $(lastword $(MAKEFILE_LIST))))
export GOBIN ?= $(PROJECT_ROOT)/bin
export PATH := $(GOBIN):$(PATH)

GOVULNCHECK = $(GOBIN)/govulncheck
BENCH_FLAGS ?= -cpuprofile=cpu.pprof -memprofile=mem.pprof -benchmem

# Directories containing independent Go modules.
Expand Down Expand Up @@ -44,9 +43,6 @@ tidy-lint:
license-lint:
./checklicense.sh

$(GOVULNCHECK):
cd tools && go install golang.org/x/vuln/cmd/govulncheck

.PHONY: test
test:
@$(foreach dir,$(MODULE_DIRS),(cd $(dir) && go test -race ./...) &&) true
Expand All @@ -72,5 +68,5 @@ updatereadme:
cat .readme.tmpl | go run internal/readme/readme.go > README.md

.PHONY: vulncheck
vulncheck: $(GOVULNCHECK)
$(GOVULNCHECK) ./...
vulncheck:
govulncheck ./...