Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed manually installation govulncheck in Makefile #1466

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Spuxy
Copy link

@Spuxy Spuxy commented Oct 22, 2024

Hello, i have changed workflow (more specifically action) to use official govulncheck and replaced this solution in Makefile to simplify that.

Motivation:
Better and more convenience way to maintain runners.

$ make all
[lint] golangci-lint: .
[lint] golangci-lint: ./exp
[lint] golangci-lint: ./benchmarks
[lint] golangci-lint: ./zapgrpc/internal/test
[lint] tidy: .
[lint] tidy: ./exp
[lint] tidy: ./benchmarks
[lint] tidy: ./zapgrpc/internal/test
./checklicense.sh
?   	go.uber.org/zap/internal	[no test files]
?   	go.uber.org/zap/internal/bufferpool	[no test files]
ok  	go.uber.org/zap	(cached)
ok  	go.uber.org/zap/buffer	(cached)
ok  	go.uber.org/zap/internal/color	(cached)
?   	go.uber.org/zap/internal/readme	[no test files]
ok  	go.uber.org/zap/internal/exit	(cached)
ok  	go.uber.org/zap/internal/pool	(cached)
ok  	go.uber.org/zap/internal/stacktrace	(cached)
ok  	go.uber.org/zap/internal/ztest	(cached)
ok  	go.uber.org/zap/zapcore	(cached)
ok  	go.uber.org/zap/zapgrpc	(cached)
ok  	go.uber.org/zap/zapio	(cached)
ok  	go.uber.org/zap/zaptest	(cached)
ok  	go.uber.org/zap/zaptest/observer	(cached)
ok  	go.uber.org/zap/exp/zapfield	(cached)
ok  	go.uber.org/zap/exp/zapslog	(cached)
ok  	go.uber.org/zap/benchmarks	(cached) [no tests to run]
ok  	go.uber.org/zap/zapgrpc/internal/test	(cached)
$ make vulncheck
govulncheck ./...
No vulnerabilities found.

Added action to install govulncheck
removed unnecessary variables
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

@Spuxy
Copy link
Author

Spuxy commented Oct 22, 2024

The problem is, that i removed the option, that will check if the binary is installed locally (the binary should be fine in runner). On the other hand, golangci-lint doesnt care as well if there is binary at local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants