Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Tag arm64 images #373

Closed
wants to merge 2 commits into from
Closed

WIP: Tag arm64 images #373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a7fd4
Tag arm64 images
dio Sep 19, 2021
0a31ee2
Remove period
dio Sep 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions .github/workflows/internal-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,34 @@ jobs:
# - needs repo:status, public_repo, write:packages, delete:packages
password: ${{ secrets.GHCR_TOKEN }}

- name: Build and push
run: | # This will only push a single architecture, which is fine as we currently only support amd64
- name: Setup QEMU
uses: docker/setup-qemu-action@v1

- name: Setup Buildx
uses: docker/setup-buildx-action@v1

- name: Write Dockerfile for ${{ matrix.target-tag }}
run: |
cat > Dockerfile <<'EOF'
${{ matrix.dockerfile }}
EOF
docker build -t ghcr.io/tetratelabs/func-e-internal:${{ matrix.target_tag }} .
docker push ghcr.io/tetratelabs/func-e-internal:${{ matrix.target_tag }}

- name : Build and push
uses: docker/build-push-action@v2
with:
context: .
platforms: linux/amd64,linux/arm64 # Build and push for amd64 and arm64 architectures.
tags: ghcr.io/${{ github.repository_owner }}/func-e-internal:${{ matrix.target-tag }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi typo: target_tag not target-tag

my guess is that if "push: true" was here it would have failed for you.


# We do re-tagging for easier usage when testing using emulation, so we can forcefuly pull
# arm64 image by directly specifiying the tag without the need of supplying
# `--platform linux/arm64`. Using `uses: docker://` only allows to override `args`, but not
# the `--platform` flag.
# Reference: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-using-the-github-packages-container-registry
# Related: https://github.com/actions/virtual-environments/issues/1368
- name : Re-tag for arm64 only
uses: docker/build-push-action@v2
with:
context: .
platforms: linux/arm64 # Build and push for arm64 architecture only.
tags: ghcr.io/${{ github.repository_owner }}/func-e-internal:${{ matrix.target-tag }}-arm64