Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Tag arm64 images #373

Closed
wants to merge 2 commits into from
Closed

WIP: Tag arm64 images #373

wants to merge 2 commits into from

Conversation

dio
Copy link
Collaborator

@dio dio commented Sep 19, 2021

This builds and pushes arm64 flavor for internal images. This is to support the idea to run the following step when testing installing/uninstalling packages on linux/arm64 (both for deb and rpm) in packaging workflow (please refer to: #366).

- uses: docker/setup-qemu-action@v1
- uses: docker://ghcr.io/tetratelabs/func-e-internal:ubuntu20.04-arm64
  with:
    args: packaging/nfpm/verify_deb.sh arm64
- uses: docker://ghcr.io/tetratelabs/func-e-internal:centos8-arm64
  with:
    args: packaging/nfpm/verify_rpm.sh aarch64

Signed-off-by: Dhi Aurrahman [email protected]

This builds and pushes arm64 flavor for internal images.

Signed-off-by: Dhi Aurrahman <[email protected]>
@dio
Copy link
Collaborator Author

dio commented Sep 19, 2021

A running action as a test is on my repo here: https://github.com/dio/gha-test/runs/3644585431 (with this workflow file: https://github.com/dio/gha-test/blob/random-images/.github/workflows/test.yaml). Not sure how to test this in this repo.

Signed-off-by: Dhi Aurrahman <[email protected]>
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to test via emulation. you'll notice many comments to please use natural architectures in testing. testing rpm via travis is fine and I prefer to not have arm64 split across multiple build systems. Doing this here is confusing further the point and probably forgetting that we have a .travis.yaml for this. I would recommend citing this when publishing two platforms, that one consumer is GH actions and the other is travis (for arm64 linux which is the only consumer of that)

As this comment about using travis for arm64 has been repeated many times, I'd prefer to take over vs saying it again.

@codefromthecrypt
Copy link
Contributor

#376 will close this

with:
context: .
platforms: linux/amd64,linux/arm64 # Build and push for amd64 and arm64 architectures.
tags: ghcr.io/${{ github.repository_owner }}/func-e-internal:${{ matrix.target-tag }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi typo: target_tag not target-tag

my guess is that if "push: true" was here it would have failed for you.

@codefromthecrypt
Copy link
Contributor

obviated by #376

@codefromthecrypt codefromthecrypt deleted the internal-images-arm64 branch September 27, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants