Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oct30 uplift third_party/tt-metal effort #1119

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

nsmithtt
Copy link
Contributor

No description provided.

@kmabeeTT
Copy link
Contributor

Plz cherry-pick a2e64a2 for some needed runtime changes to solve compile error that goes with metal PR tenstorrent/tt-metal#14394

@mtopalovicTT
Copy link
Contributor

@nsmithtt
Not sure if possible to include this also?
tenstorrent/tt-metal@948fafb

@mbezuljTT
Copy link
Contributor

we have a bigger problem with merges, when we solve it - these will be automated again.

@kmabeeTT
Copy link
Contributor

kmabeeTT commented Nov 4, 2024

Comment on CI fails, one error is:

2024-11-01 16:16:18,806 - DEBUG - starting loop=1/1 for binary=test_perf_slice.mlir.ttnn
                 Always | FATAL    | Physical size (32, 16) must be multiple of page size (1, 32)
2024-11-01 16:16:19,059 - ERROR - ERROR: test=test_perf_slice.mlir.ttnn experienced an error with exception=TT_FATAL @ /localdev/kmabee/mlir2/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/tensor/layout/tensor_layout.cpp:97: width_remainder == 0 && height_remainder == 0

Talked to Artem on Friday and he said tt-metal bug and fix is coming ...soon...

Edit: Unconfirmed if we need to fix something here, but metal PR Artem referring to is tenstorrent/tt-metal#14550

@nsmithtt
Copy link
Contributor Author

nsmithtt commented Nov 4, 2024

We'll need this UMD fix: tenstorrent/tt-umd#251 (comment)

@mbezuljTT
Copy link
Contributor

We'll need this UMD fix: tenstorrent/tt-umd#251 (comment)

@broskoTT we're fixing metal in mlir repo. do you know if umd uplifts regularly to metal repo or would be better for us to do it on our own?

nsmithtt and others added 3 commits November 6, 2024 18:26
 - Switch to tt-metal branch w/ 3 PR's cherry picked to solve
   refactoring issues with TensorLayout
…n tt-metal

 - Matches changes from tt-metal PR 14394
@kmabeeTT kmabeeTT changed the title Uplift third_party/tt-metal to dec1dc2c6da1d547535bedb11d41f6373c66a69f Oct30 uplift third_party/tt-metal effort Nov 6, 2024
@kmabeeTT
Copy link
Contributor

kmabeeTT commented Nov 6, 2024

Small update. Renamed PR, and cherry picked 3 metal PR's (2 from Friday, 1 from today) and the failing tests in last week's CI run we saw are gone. Rebased and force pushed this branch as we are getting close. Going to try to test on Forge-FE too.

I haven't seen need for UMD fix referenced above though, or at least I didn't do anything, I get impression it's needed only for newer tt-metal not the Oct30 base we are still targeting with this uplift. tt-mlir is currently using Oct25 tt-metal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants