Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: More suggestions from Anba #3004

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Editorial: More suggestions from Anba #3004

merged 4 commits into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. Editorial: Add ISODateWithinLimits check to CalendarMonthDayFromFields 

    This was previously not thought necessary, but some month-day combinations
are rare enough in the Chinese lunar calendar that they might occur only
outside of the representable range.

Failing this check would hit an assertion elsewhere anyway, so this is
editorial.

Closes: #2997
    @ptomato @Ms2ger
    ptomato authored and Ms2ger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d9fd5f9 View commit details
    Browse the repository at this point in the history

  2. Editorial: Second argument to CalendarExtraFields is only a List 

    The enum values are no longer passed anywhere in the spec text, so remove
them as a permissible type. Update the polyfill implementation to match,
which had a bug; it always assumed ~date~, which was incorrect.

Closes: #2999
    @ptomato @Ms2ger
    ptomato authored and Ms2ger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fac0955 View commit details
    Browse the repository at this point in the history

  3. Editorial: Move PrepareCalendarFields into calendar section 

    See: #3001
    @ptomato @Ms2ger
    ptomato authored and Ms2ger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1ef906e View commit details
    Browse the repository at this point in the history

  4. Editorial: Give field names lists to PrepareCalendarFields in table o… 

    …rder

It's easier to inspect at a glance which fields are included when they are
given in order. This order is not observable because the list is sorted
by lexicographical order anyway before being used to access properties.

See: #3001
    @ptomato @Ms2ger
    ptomato authored and Ms2ger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e049468 View commit details
    Browse the repository at this point in the history