Editorial: More suggestions from Anba #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
+ Coverage 95.88% 95.89% +0.01%
==========================================
Files 21 21
Lines 9674 9678 +4
Branches 1836 1837 +1
==========================================
+ Hits 9276 9281 +5
+ Misses 345 344 -1
Partials 53 53 ☔ View full report in Codecov by Sentry. |
This was previously not thought necessary, but some month-day combinations are rare enough in the Chinese lunar calendar that they might occur only outside of the representable range. Failing this check would hit an assertion elsewhere anyway, so this is editorial. Closes: #2997
The enum values are no longer passed anywhere in the spec text, so remove them as a permissible type. Update the polyfill implementation to match, which had a bug; it always assumed ~date~, which was incorrect. Closes: #2999
…rder It's easier to inspect at a glance which fields are included when they are given in order. This order is not observable because the list is sorted by lexicographical order anyway before being used to access properties. See: #3001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @anba
Closes: #2997, #2999, #3001