Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow sphinx versions 5.x #179

Closed
wants to merge 2 commits into from

Conversation

renefritze
Copy link

AFAICT there was no real need to limit the sphinx version to <5, right?
In general, wouldn't it also suffice to transitively depend on the sphinx versions via breathe's requirements?

@renefritze
Copy link
Author

Some failures indicate that there's a more general problem with the CI setup @svenevs .

@njzjz
Copy link

njzjz commented Mar 24, 2023

Some failures indicate that there's a more general problem with the CI setup @svenevs .

I fixed the problem in #189.

I also hope this PR can be merged.

@svenevs
Copy link
Owner

svenevs commented Mar 29, 2023

thank you for the contribution and nudges! i cherry picked these into #190 folding into a larger "fix it all" pr. sorry it has taken so long to get any movement here, there's oodles of technical debt

AFAICT there was no real need to limit the sphinx version to <5, right?

that yaml thing was a little confusing, what >=4,<5 was saying was "any 4.x" version, specifically "anything greater than or equal to 4, and less than 5" meaning pip will choose latest sphinx 4.x release

that was primarily there to be testing against the latest version in CI, but of course went stale many moons ago

In general, wouldn't it also suffice to transitively depend on the sphinx versions via breathe's requirements?

yes, that used to be the world order, at some point I think we were having issues with a breathe release or needed to support installing their main branch or something -- I remember it happening, hacking, and planning to undo it. going to do an audit there, plan is in #191

@svenevs svenevs closed this Mar 29, 2023
svenevs pushed a commit that referenced this pull request Mar 29, 2023
Restore CI functionality and misc related cosmetic changes.

- Fix tox 4 compatibility issue (`passenv` needs multiple lines).
    - Thanks @njzjz (cherry-picks #189)!
- Loosen sphinx version packaging requirements (allow up to sphinx 6.x)
    - Thanks @renefritze (cherry-picks #179)!
- Fix outdated bs4 intersphinx mapping (thanks @florianhumblot)!
- Fix linkcheck redirect urls (primarily: `http` => `https`).
- Expand python testing matrix to include python 3.11.
- Windows CI: doxygen 1.8.6 => 1.9.6.
- Expanded sphinx version testing to include all supported major versions.
- Add PR autocancel (`concurrency`) and fail-fast to save time on CI.
@renefritze renefritze deleted the update_sphinx_pin branch March 29, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants