Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context shim override behavior #723

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Fix context shim override behavior #723

merged 2 commits into from
Mar 3, 2024

Conversation

andrehjr
Copy link
Member

@andrehjr andrehjr commented Mar 3, 2024 •
edited
Loading

Building this on top of #721

  • Refactored specs a bit, to not depend on spec_helper for everything
  • Minor changes when verifying if request/params were present or not

@andrehjr andrehjr mentioned this pull request Mar 3, 2024
Merged
@andrehjr andrehjr force-pushed the fix-context-shim-override-behavior branch from 971673b to 397dc47 Compare March 3, 2024 14:27
@andrehjr andrehjr merged commit f34f68d into main Mar 3, 2024
11 checks passed
@andrehjr andrehjr deleted the fix-context-shim-override-behavior branch March 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrehjr