Fix context shim override behavior #721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll try to summarize the problem as much as possible:
The split has this class:
Which includes:
If we use the context shim this way:
inside a high level abstraction, we got a problem.
Problem
The override of ab via URL (
?ab_test[my_test]=variant
) and Split panel (cookies) doesn't work.It doesn't work because
Split::Helper
uses these methods:Which depend on
defined?(params)
anddefined?(request)
, which are in@context
but not in the scope ofContextShim
.In other words:
If we add params and request to the scope of
ContextShim
, we can solve the problem.Solution
Include these methods in
ContextShim
:I also create a
request_present?
andparams_present?
methods inSplit::Helper
to avoid problems when request or params are defined but returningnil
: This is the case when@context
don't implementrequest
orparams