Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default suffix to ELP #1378

Merged
merged 11 commits into from
Aug 23, 2024
Merged

Add a default suffix to ELP #1378

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
18c2928
add a default suffix to ELP
nden Aug 22, 2024
cf4980d
remove all occurences of suffix in the elp
nden Aug 22, 2024
c0be70a
add a change log entry
nden Aug 22, 2024
e2fa2f2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 22, 2024
12c6c01
add a test
nden Aug 22, 2024
cba39ca
Merge branch 'elp-suffix' of github.com:nden/romancal into elp-suffix
nden Aug 22, 2024
9ad11a4
correct test docstring
nden Aug 22, 2024
4353100
Update romancal/regtest/test_wfi_pipeline.py
nden Aug 23, 2024
855da88
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 23, 2024
195cc8d
fix status
nden Aug 23, 2024
51b49de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions romancal/pipeline/exposure_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class ExposurePipeline(RomanPipeline):
spec = """
save_calibrated_ramp = boolean(default=False)
save_results = boolean(default=False)
suffix = string(default="cal")
"""

# Define aliases to steps
Expand Down Expand Up @@ -179,8 +180,6 @@ def process(self, input):
result.meta.cal_step.tweakreg = "SKIPPED"
self.suffix = "cal"

self.setup_output(result)

self.output_use_model = True
results.append(result)

Expand All @@ -193,10 +192,6 @@ def process(self, input):

return results

def setup_output(self, input):
"""Determine the proper file name suffix to use later"""
self.suffix = "cal"

def create_fully_saturated_zeroed_image(self, input_model):
"""
Create zeroed-out image file
Expand Down