Add a default suffix to ELP

[nden]

Resolves RCAL-898

Closes #1379

This PR addresses an issue in OPS where files generated from the ELP do not have the expected suffix.
With this change passing --sufix= to the strun command generates output with the specified suffix. If no suffix is passed, the default suffix is cal.

Checklist

• added entry in CHANGES.rst under the corresponding subsection
• updated relevant tests
• updated relevant documentation
• updated relevant milestone(s)
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

[nden]

Marking it as Draft because it needs a test and until it's confirmed this is what SDP needs.

[ddavis-stsci]

With this fix in place I get
for run_elpp.csh
[stpipe.ExposurePipeline.source_catalog] Saved model in ```
r0000101001001001001_01101_0002_WFI10_sourcecatalog.asdf
2024-08-22 15:32:58,667 - stpipe.ExposurePipeline.source_catalog - INFO - Step source_catalog done
[stpipe.ExposurePipeline.source_catalog] Step source_catalog done
[ root] Number of models to tweakreg: (1, 1)
[ root] teakreg STATUS: <romancal.tweakreg.tweakreg_step.TweakRegStep object at 0x16ceef4d0>
[ root] suffix sourcedetection
2024-08-22 15:32:58,716 - stpipe.ExposurePipeline.tweakreg - INFO - Step tweakreg running with args ([<roman_datamodels.datamodels._datamodels.ImageModel object at 0x16d82b710>],).
[stpipe.ExposurePipeline.tweakreg] Step tweakreg running with args ([<roman_datamodels.datamodels._datamodels.ImageModel object at 0x16d82b710>],).
2024-08-22 15:32:58,716 - stpipe.ExposurePipeline.tweakreg - INFO - Step skipped.
[stpipe.ExposurePipeline.tweakreg] Step skipped.
[ root] Roman exposure calibration pipeline ending...
2024-08-22 15:32:59,486 - stpipe.ExposurePipeline - INFO - Saved model in r0000101001001001001_01101_0002_WFI10_sourcedetection.asdf

running tweakreg
I get the expected files (this is one example)

2024-08-22 15:40:49,833 - stpipe.TweakRegStep - INFO - Saved model in r0000101001001001001_01101_0002_WFI10_cal.asdf
2024-08-22 15:40:49,833 - stpipe.TweakRegStep - INFO - Step TweakRegStep done

So it appears that it is now running as I expect. 

[braingram]

Regtests running at: https://github.com/spacetelescope/RegressionTests/actions/runs/10514634684

EDIT: restarted these after the addition of the new regtest

[ddavis-stsci]

Local tests in the comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (b24429c) to head (51b49de).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
+ Coverage   78.58%   78.61%   +0.03%     
==========================================
  Files         117      117              
  Lines        7862     7856       -6     
==========================================
- Hits         6178     6176       -2     
+ Misses       1684     1680       -4     

Flag	Coverage Δ		*Carryforward flag
nightly	62.24% <ø> (-0.03%)	⬇️	Carriedforward from 855da88

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[braingram]

Thanks! LGTM.

[braingram]

Good catch.

There's an open issue already for why this isn't SKIPPED: spacetelescope/roman_datamodels#343