Fix syntax of argument to cmake (#26).
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The page describing how to use the dashboard states that colcon build has to be called with arguments `--cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS`, which is not valid syntax because variables have to be given a value. This commit modifies that sentence to indicate that the value should be `ON`.
ivanperez-keera
force-pushed
the
dev-cmake-args-syntax
branch
from
a9f90c1
to
876704f
Compare
Bckempa
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page describing how to use the dashboard states that colcon build has to be called with arguments
--cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS, which is not valid syntax because variables have to be given a value.This commit modifies that sentence to indicate that the value should be
ON.