-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor error in Use-The-Dashboard.rst
#26
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Milestone
Comments
ivanperez-keera
added
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Jan 11, 2024
ivanperez-keera
changed the title
Minor error in
Minor error in Jan 11, 2024
Use-The-Dashboard.html
Use-The-Dashboard.rst
ivanperez-keera
added a commit
that referenced
this issue
Jan 11, 2024
The page describing how to use the dashboard states that colcon build has to be called with arguments `--cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS`, which is not valid syntax because variables have to be given a value. This commit modifies that sentence to indicate that the value should be `ON`.
ivanperez-keera
added a commit
that referenced
this issue
Jan 11, 2024
The page describing how to use the dashboard states that colcon build has to be called with arguments `--cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS`, which is not valid syntax because variables have to be given a value. This commit modifies that sentence to indicate that the value should be `ON`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
The page describing how to use the dashboard states that
colcon build
has to be called with arguments:This is not valid syntax. It should be:
Offending line:
https://github.com/space-ros/docs/blob/dd8cff49220293c16884ba25b776b7db2f8cecc2/source/How-To-Guides/Use-The-Dashboard.rst?plain=1#L23C27-L23C27
The text was updated successfully, but these errors were encountered: