Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add com.snowplowanalytics.mobile/application_lifecycle/jsonschema/1-0-0 (close #1131) #1132

Closed
wants to merge 2 commits into from
Closed

Add com.snowplowanalytics.mobile/application_lifecycle/jsonschema/1-0-0 (close #1131) #1132

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
820701d
Add application_lifecycle entity schema
AlexBenny Sep 13, 2021
85587d9
Remove default property
AlexBenny Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions schemas/com.snowplowanalytics.mobile/application_lifecycle/jsonschema/1-0-0
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"$schema": "http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#",
"description": "Entity that indicates the visibility state of the app (foreground, background)",
"self": {
"vendor": "com.snowplowanalytics.mobile",
"name": "application_lifecycle",
"format": "jsonschema",
"version": "1-0-0"
},

"type": "object",
"properties": {
"isVisible": {
"description": "Indicates if the app is in foreground state (true) or background state (false)",
"type": "boolean",
"default": true
Copy link
Contributor

@chuwy chuwy Sep 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I certainly don't have anything against default, but just in case - it won't be used anywhere (Iglu doesn't support it explicitly). Thus tables will be generated as NOT NULL and if user doesn't provide it - the loading will fail. Some more context:

We can use it as purely informational, although I afraid it encourages bad behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree 👍 I don't even know where I got it. That value is always set in the tracker so no need to specify this here.

},
"index": {
"description": "Represents the foreground index or background index (tracked with com.snowplowanalytics.snowplow application_foreground and application_background events.",
"type": "integer",
"minimum": 0,
"maximum": 2147483647
}
},
"required": ["isVisible"],
"additionalProperties": false
}