Add com.snowplowanalytics.mobile/application_lifecycle/jsonschema/1-0-0 (close #1131) #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuwy
suggested changes
Sep 15, 2021
| "isVisible": { | ||
| "description": "Indicates if the app is in foreground state (true) or background state (false)", | ||
| "type": "boolean", | ||
| "default": true |
There was a problem hiding this comment.
I certainly don't have anything against default, but just in case - it won't be used anywhere (Iglu doesn't support it explicitly). Thus tables will be generated as NOT NULL and if user doesn't provide it - the loading will fail. Some more context:
- Schema DDL: add default value for JSON property if default provided iglu#248
- Add method for injecting defaults iglu-scala-client#76
We can use it as purely informational, although I afraid it encourages bad behavior.
There was a problem hiding this comment.
I agree 👍 I don't even know where I got it. That value is always set in the tracker so no need to specify this here.
chuwy
approved these changes
Sep 20, 2021
|
Closing in favor of #1139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the related issue, here is the schema for application_lifecycle entity.
The entity is attached to all the events by the tracker based on the app state (foreground or background).
For reference iOS PR: snowplow/snowplow-ios-tracker#637