Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oct6 le fixes #454

Merged
merged 22 commits into from
Oct 7, 2023
Merged

Oct6 le fixes #454

merged 22 commits into from
Oct 7, 2023

Commits on Oct 6, 2023

  1. quick cleanup

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    223d868 View commit details
    Browse the repository at this point in the history

  2. clean up

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c4a645e View commit details
    Browse the repository at this point in the history

  3. clean up

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    bcb0507 View commit details
    Browse the repository at this point in the history

  4. Fix sum-of-simple-terms testcase in light of changes to IS handling

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    8ca9d83 View commit details
    Browse the repository at this point in the history

  5. clean up

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ed8a4c5 View commit details
    Browse the repository at this point in the history

  6. LE: Fix overgeneration of NLAs for things of form blah|IS|blah2 whe… 

    …re `blah2` does not start with num.

New convention: generate NLA ONLY for IS|<number> and NEVER for any other instance of `blahs|IS|blah2s`
    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e080b05 View commit details
    Browse the repository at this point in the history

  7. LE: Add test for overgeneration of NLAs fix

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    3998d17 View commit details
    Browse the repository at this point in the history

  8. clean up

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    bfc7688 View commit details
    Browse the repository at this point in the history

  9. Update docs in light of IS changes

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    8903308 View commit details
    Browse the repository at this point in the history

  10. Add within comparison to builtins

    @joewatt95
    joewatt95 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0bdd5fd View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into oct6-le-fixes

    @joewatt95
    joewatt95 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c5cb9e3 View commit details
    Browse the repository at this point in the history

  12. LE: Don't generate NLA from a condition with an AposVar (i.e., a give… 

    …n var that ends with `'s`)
    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    45f9d25 View commit details
    Browse the repository at this point in the history

  13. LE: Add test for <Don't generate NLA from a condition with an AposVar… 

    … (i.e., a given var that ends with `'s`)>
    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c2bd4ce View commit details
    Browse the repository at this point in the history

  14. LE: Have decimals use fixed / standard instead of scientific notation

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2655c69 View commit details
    Browse the repository at this point in the history

  15. replace clause numbers

    @joewatt95
    joewatt95 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    045cfaf View commit details
    Browse the repository at this point in the history

  16. tweak repl of clause nums

    @joewatt95
    joewatt95 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    369712b View commit details
    Browse the repository at this point in the history

  17. formatting

    @joewatt95
    joewatt95 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2ffa99e View commit details
    Browse the repository at this point in the history

  18. appease linter

    @joewatt95
    joewatt95 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    232f0fa View commit details
    Browse the repository at this point in the history

  19. format imports

    @joewatt95
    joewatt95 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ce3809c View commit details
    Browse the repository at this point in the history

  20. GenLEHCs: Add import list for LS.XPile.LogicalEnglish.Types

    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5605b82 View commit details
    Browse the repository at this point in the history

  21. LE: Don't generate NLA for conditions with cells that end with "'s" (… 

    …but do add a 'a ' prefix for a cell that matches GIVEN var and ends with "'s")
    @ym-han
    ym-han committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    77b2cac View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. replace inf, cleanup

    @joewatt95
    joewatt95 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    2b1fe71 View commit details
    Browse the repository at this point in the history