Oct6 le fixes #454
Merged
Oct6 le fixes #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re `blah2` does not start with num. New convention: generate NLA ONLY for IS|<number> and NEVER for any other instance of `blahs|IS|blah2s`
…n var that ends with `'s`)
… (i.e., a given var that ends with `'s`)>
…but do add a 'a ' prefix for a cell that matches GIVEN var and ends with "'s")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have decimals use fixed / standard instead of scientific notation
Fix overgeneration of NLAs for things of form
blah|IS|blah2whereblah2does not start with num.blahs|IS|blah2sFix existing tests and add a few new tests for above
Fix and add to docstrings in light of above
Joe: add to list of built in templates; replace clause numbers
Misc clean up, like adding import list for LS.XPile.LogicalEnglish.Types to GenLEHCs