Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

285 search #294

Merged
merged 3 commits into from
Apr 22, 2024
Merged

285 search #294

merged 3 commits into from
Apr 22, 2024

Conversation

sroertgen
Copy link
Contributor

@sroertgen
WIP Add scopeNote to search widget #285
0f62218
@sroertgen
Add scopeNote as searchable field. #285
9ebdd20 
Added test for scopeNote.
Added documentation on how to add searchable fields.
@sroertgen sroertgen requested a review from acka47 March 28, 2024 09:25
@sroertgen sroertgen assigned sroertgen and acka47 and unassigned acka47 Mar 28, 2024
@sroertgen sroertgen removed the request for review from acka47 March 28, 2024 09:25
@sroertgen
Copy link
Contributor Author

After #293 is merged, I will merge this into dev for testing.

@sroertgen sroertgen linked an issue Mar 28, 2024 that may be closed by this pull request
Allow search in scopeNotes, adjust search widget text #285
Closed
@sroertgen sroertgen mentioned this pull request Apr 9, 2024
Merged
@sroertgen sroertgen requested a review from acka47 April 19, 2024 06:55
@sroertgen
Copy link
Contributor Author

@acka47 merged into dev for testing.

acka47
acka47 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine at https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/w3id.org/kim/hcrt/index.html

I just noticed the problem with https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/w3id.org/kim/hcrt/index.html showing the concept scheme description but this might not be related with this PR. If this behaviour is not introduced on production with this PR: +1

@sroertgen sroertgen merged commit d28480c into main Apr 22, 2024
3 checks passed
@sroertgen sroertgen deleted the 285-search branch April 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acka47 acka47 acka47 approved these changes

Assignees

@acka47 acka47

@sroertgen sroertgen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow search in scopeNotes, adjust search widget text
2 participants
@sroertgen @acka47