Add concept scheme to embedded concepts #295 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concept scheme was not yet added to the embedded concepts for hash uris. If visiting a hash uri concept scheme directly this resulted in a crash.
|
Merged into How to test:
if it's not crashing it's working. |
acka47
added a commit
to acka47/testing-skohub-vocabs
that referenced
this pull request
Apr 22, 2024
...for reviewing skohub-io/skohub-vocabs#296
|
It's not crashing but it also looks different than the non
In the second case there is another box around the concept scheme description:
|
Moves the CSS out of the component and thereby aligns the display of concepts, conept schemes and collections.
|
@acka47 Good catch, like always! I aligned the design and pushed the changes to the test container. Please test again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept scheme was not yet added to the embedded concepts for hash uris. If visiting a hash uri concept scheme directly this resulted in a crash.
Will deploy this to test system after #293 #294 are merged.