FEATURE: Add unit and functional tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradinarufelix
force-pushed
the
FEATURE/testing
branch
20 times, most recently
from
376e0df
to
7062978
Compare
…simplify code and switch to PHP8 style
gradinarufelix
force-pushed
the
FEATURE/testing
branch
from
ea693cb
to
ab312ec
Compare
gradinarufelix
force-pushed
the
FEATURE/testing
branch
from
ab312ec
to
27f8eed
Compare
This reverts commit 9da4525.
gradinarufelix
force-pushed
the
FEATURE/testing
branch
from
87d6715
to
271483a
Compare
gradinarufelix
changed the title
Flush context caches and use correct instance of ContextFactory to avoid dangling Workspace references.
TASK: Fix Workspace persistence error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extensive unit and functional testing for this package. Everything about how to run these tests is described in the new
TESTING.mdfile, see: https://github.com/sitegeist/Sitegeist.LostInTranslation/blob/4a9788bc462253ba936c8c6b12222dc6981a02b9/TESTING.mdThe functional testing already covers quite some cases. Unfortunately, there are still some tests that I could not finish. Those tests are not annotated with
@testbut instead with_testand an explanation what goes wrong.